Skip to content

[None][infra] Waive failed A10-PyTorch-1 test in pre-merge#12207

Merged
ZhanruiSunCh merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/waive_failed_a10_test_in_premerge
Mar 14, 2026
Merged

[None][infra] Waive failed A10-PyTorch-1 test in pre-merge#12207
ZhanruiSunCh merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/waive_failed_a10_test_in_premerge

Conversation

@yuanjingx87
Copy link
Collaborator

@yuanjingx87 yuanjingx87 commented Mar 13, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests
    • Updated test execution configuration to exclude a specific test variant from running.

Description

Waive failed test in A10-PyTorch-1

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yuanjingx87
Waive failed A10-PyTorch-1 test in pre-merge
56bc06a 
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@yuanjingx87
Copy link
Collaborator Author

yuanjingx87 commented Mar 13, 2026

/bot run --stage-list "A10-PyTorch-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A test skip entry was added to the waives list for a specific test case in the disaggregated test suite. The entry indicates that the test unittest/disaggregated/test_agent_multi_backends.py::test_run_with_different_env[1] should be skipped during test execution.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt		 Added skip entry for unittest/disaggregated/test_agent_multi_backends.py::test_run_with_different_env[1] to the test waives list in two locations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal and lacks critical details about the waived test and reasoning. Add explanation of which test is being waived, why it's failing, expected timeline for fix, and relevant tracking ticket if available.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: waiving a failed test for A10-PyTorch-1 infrastructure in pre-merge, matching the changeset which adds skip entries to the test waive list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 13, 2026

PR_Github #38920 [ run ] triggered by Bot. Commit: 56bc06a Link to invocation

@ZhanruiSunCh ZhanruiSunCh enabled auto-merge (squash) March 14, 2026 01:39
@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 14, 2026

PR_Github #38920 [ run ] completed with state SUCCESS. Commit: 56bc06a
/LLM/main/L0_MergeRequest_PR pipeline #30225 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@EmmaQiaoCh
Copy link
Collaborator

EmmaQiaoCh commented Mar 14, 2026

/bot skip --comment "Waive failed case"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 14, 2026

PR_Github #38935 [ skip ] triggered by Bot. Commit: 56bc06a Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 14, 2026

PR_Github #38935 [ skip ] completed with state SUCCESS. Commit: 56bc06a
Skipping testing for commit 56bc06a

Link to invocation

@ZhanruiSunCh ZhanruiSunCh merged commit 3380889 into NVIDIA:main Mar 14, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhanruiSunCh ZhanruiSunCh ZhanruiSunCh approved these changes

Assignees

@yuanjingx87 yuanjingx87

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuanjingx87 @tensorrt-cicd @EmmaQiaoCh @ZhanruiSunCh